Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script/release-candidate should fail if destination branch is not master #509

Closed
shawnbot opened this issue Jun 20, 2018 · 1 comment
Closed
Labels
area: tooling 💓collab a vibrant hub of collaboration Tag: Internal

Comments

@shawnbot
Copy link
Contributor

As evidenced by #502, it's quite possible to accidentally merge a release branch into dev. I'm out of practice here, but it would be nice to have a guard against this, either as a CI failure or maybe a Probot?

@shawnbot shawnbot added area: tooling Tag: Internal 💓collab a vibrant hub of collaboration labels Jun 20, 2018
@jonrohan
Copy link
Member

This would be too aggressive because there are situations where we might want to merge a branch somewhere else other than master. The approach we're taking instead is to do away with the dev branch #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling 💓collab a vibrant hub of collaboration Tag: Internal
Projects
None yet
Development

No branches or pull requests

2 participants