Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Popover caret position and distance from origin #476

Closed
shawnbot opened this issue May 1, 2018 · 1 comment
Closed

Revisit Popover caret position and distance from origin #476

shawnbot opened this issue May 1, 2018 · 1 comment
Labels
💓collab a vibrant hub of collaboration css Stale Automatically marked as stale. Tag: Polish

Comments

@shawnbot
Copy link
Contributor

shawnbot commented May 1, 2018

This is a follow-on issue for #465, specifically this thread regarding two aspects of the Popover component:

  1. The distance of the caret (triangular part) varies between horizontal and vertical orientations. It probably shouldn't.
  2. @pifafu suggested that the point at the end of the caret be offset from its "origin" point, possibly somewhere between 2 and 3 spacing units.

While we're in there we should tidy up this mess of SCSS, and possibly incorporate "standard" caret styles as discussed in github/design-systems#406.

@github-actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label May 26, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💓collab a vibrant hub of collaboration css Stale Automatically marked as stale. Tag: Polish
Projects
None yet
Development

No branches or pull requests

2 participants