Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline tooltip wraps too eagerly on Edge #436

Closed
kevinsawicki opened this issue Jan 16, 2018 · 3 comments
Closed

Multiline tooltip wraps too eagerly on Edge #436

kevinsawicki opened this issue Jan 16, 2018 · 3 comments

Comments

@kevinsawicki
Copy link

kevinsawicki commented Jan 16, 2018

The multiline tooltip on Edge seems to wrap too eagerly on Edge.

Visiting https://styleguide.github.com/primer/components/tooltips/#tooltips-with-multiple-lines in Edge 40.15063.674.0 shows the following:

screen shot 2018-01-16 at 3 37 07 pm

Not sure what the best fix is here but if I remove this line:

https://github.com/primer/primer/blob/6a90859d2274c47488f8c3e170b0727b3c71f34c/modules/primer-tooltips/lib/tooltips.scss#L241

Then the tooltip no longer eagerly wraps:

screen shot 2018-01-16 at 3 41 42 pm

@broccolini
Copy link
Member

Thanks for reporting the issue @kevinsawicki we'll test your suggestion out and aim to get this in our next release. Holla if fixing this is a high priority for you.

@agross
Copy link

agross commented Feb 7, 2018

Firefox showed a similar behavior for me. Adding width: -moz-max-content helped. Edge is also broken for me.

@github-actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label May 26, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants