New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate colorizeTooltip mixin #403

Closed

2 tasks done

broccolini opened this issue Nov 15, 2017 · 1 comment

Labels

Member

broccolini commented Nov 15, 2017 •

edited by shawnbot

Loading

This doesn't appear to be used anywhere and not sure why we would want to use it either.

https://github.com/primer/primer/blob/c865391eaa1aa743f9ca3c24133cc30efa51acbd/modules/primer-tooltips/lib/tooltips.scss#L242-L272

To do:

Add deprecation warning in minor release
Remove Sass in major release

broccolini added major release minor release labels

This was referenced Feb 28, 2018

10.4.0 Release Tracking #451

Closed

Add colorizeTooltip deprecation warning #455

Merged

shawnbot removed the minor release label

Contributor

shawnbot commented Feb 8, 2019

This was done in #656 and released in #498.

shawnbot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment