Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test to make sure licenses and header comments have correct year #378

Closed
jonrohan opened this issue Oct 24, 2017 · 3 comments
Closed

Comments

@jonrohan
Copy link
Member

I would like the build to fail if the current year doesn't match the year in the LICENSE files. So we'll know to update when the year changes.

Same goes for the header files in the modules.

https://github.com/primer/primer-css/blob/master/modules/primer-css/index.scss#L1-L6

@agisilaos
Copy link
Contributor

Love the idea @jonrohan!
For now, do we need to change this part

https://github.com/primer/primer-css/blob/3190c9cbae211b2ba04b15851245e79328002d60/modules/primer-css/index.scss#L1-L6

to this part:

Released under MIT license. Copyright 2017 GitHub, Inc. ?

@jonrohan
Copy link
Member Author

I'll fix them up in the test PR, good test material.

@jonrohan
Copy link
Member Author

jonrohan commented Nov 2, 2017

Fixed in #384

@jonrohan jonrohan closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants