Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate plugin-options tests #40

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Feb 18, 2025

Copies the plugin-option tests from prettier.

Note that these will need updating once #39 and #21 are fixed.

@fabiospampinato
Copy link
Collaborator

Note that these will need updating once #39 and #21 are fixed.

#39 got merged, could you do the updates for that?

We can think about the updates for #21 later, that's trickier.

@43081j 43081j force-pushed the test-plugin-options branch from d2f458d to 99d7296 Compare February 23, 2025 15:50
Copies the `plugin-option` tests from prettier.

Note that these will need updating once prettier#39 and prettier#21 are fixed.
@43081j 43081j force-pushed the test-plugin-options branch from 99d7296 to 4440845 Compare February 23, 2025 15:51
@43081j
Copy link
Contributor Author

43081j commented Feb 23, 2025

should be sorted 👍

@fabiospampinato fabiospampinato merged commit 8d552a3 into prettier:main Feb 23, 2025
2 checks passed
@fabiospampinato
Copy link
Collaborator

Thanks, I'll delete the --help option tests as we don't support them and unless that turns out to be a problem I don't think we need to support that at all, especially as I haven't see particularly useful information provided by the CLI when asking for information about an option.

@43081j 43081j deleted the test-plugin-options branch February 23, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants