Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TPC-H connector in presto native execution #18335

Closed
majetideepak opened this issue Sep 12, 2022 · 3 comments
Closed

Add support for TPC-H connector in presto native execution #18335

majetideepak opened this issue Sep 12, 2022 · 3 comments
Assignees
Labels
prestissimo Presto Native Execution

Comments

@majetideepak
Copy link
Collaborator

Velox already supports the TPC-H connector. We need to bind presto native execution with this.

@majetideepak majetideepak added the prestissimo Presto Native Execution label Sep 12, 2022
@majetideepak majetideepak self-assigned this Sep 18, 2022
@Mionsz
Copy link
Contributor

Mionsz commented Nov 3, 2022

@majetideepak
I am getting this when trying to build with TPCH support:

[445/503] Building CXX object presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxSplit.cpp.o
FAILED: presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxSplit.cpp.o
/opt/rh/gcc-toolset-9/root/bin/g++  -DBOOST_ALL_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DFMT_LOCALE -DGFLAGS_IS_A_DLL=0 -DPRESTO_ENABLE_HDFS -DPRESTO_ENABLE_PARQUET -DPRESTO_ENABLE_S3 -DVELOX_DISABLE_GOOGLETEST -I../../. -I../../velox -I../../velox/velox/external/xxhash -Ivelox -I../../velox/third_party/xsimd/include -Ivelox/velox/dwio/dwrf/proto/../../../.. -isystem /usr/include/antlr4-runtime -isystem /usr/include/proxygen -isystem /usr/include/libdwarf -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -O3 -DNDEBUG -fPIC   -std=gnu++17 -MD -MT presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxSplit.cpp.o -MF presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxSplit.cpp.o.d -o presto_cpp/main/types/CMakeFiles/presto_types.dir/PrestoToVeloxSplit.cpp.o -c ../../presto_cpp/main/types/PrestoToVeloxSplit.cpp
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp: In function 'facebook::velox::exec::Split facebook::presto::toVeloxSplit(const facebook::presto::protocol::ScheduledSplit&)':
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:77:56: error: ISO C++ forbids declaration of 'type name' with no type [-fpermissive]
   77 |   if (auto tpchSplit = std::dynamic_pointer_cast<const protocol::TpchSplit>(
      |                                                        ^~~~~~~~
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:77:29: error: parse error in template argument list
   77 |   if (auto tpchSplit = std::dynamic_pointer_cast<const protocol::TpchSplit>(
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:78:25: error: no matching function for call to 'dynamic_pointer_cast<<expression error> >(const std::shared_ptr<facebook::presto::protocol::ConnectorSplit>&)'
   78 |           connectorSplit)) {
      |                         ^
In file included from /opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/shared_ptr.h:52,
                 from /opt/rh/gcc-toolset-9/root/usr/include/c++/9/memory:81,
                 from /opt/rh/gcc-toolset-9/root/usr/include/c++/9/regex:45,
                 from ../.././presto_cpp/presto_protocol/presto_protocol.h:25,
                 from ../.././presto_cpp/main/types/PrestoToVeloxSplit.h:16,
                 from ../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:14:
/opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/shared_ptr_base.h:1558:5: note: candidate: 'template<class _Tp, class _Tp1, __gnu_cxx::_Lock_policy _Lp> std::__shared_ptr<_Tp1, _Lp> std::dynamic_pointer_cast(const std::__shared_ptr<_Tp2, _Lp>&)'
 1558 |     dynamic_pointer_cast(const __shared_ptr<_Tp1, _Lp>& __r) noexcept
      |     ^~~~~~~~~~~~~~~~~~~~
/opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/shared_ptr_base.h:1558:5: note:   template argument deduction/substitution failed:
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:78:25: error: template argument 1 is invalid
   78 |           connectorSplit)) {
      |                         ^
In file included from /opt/rh/gcc-toolset-9/root/usr/include/c++/9/memory:81,
                 from /opt/rh/gcc-toolset-9/root/usr/include/c++/9/regex:45,
                 from ../.././presto_cpp/presto_protocol/presto_protocol.h:25,
                 from ../.././presto_cpp/main/types/PrestoToVeloxSplit.h:16,
                 from ../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:14:
/opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/shared_ptr.h:507:5: note: candidate: 'template<class _Tp, class _Up> std::shared_ptr<_Tp> std::dynamic_pointer_cast(const std::shared_ptr<_Tp>&)'
  507 |     dynamic_pointer_cast(const shared_ptr<_Up>& __r) noexcept
      |     ^~~~~~~~~~~~~~~~~~~~
/opt/rh/gcc-toolset-9/root/usr/include/c++/9/bits/shared_ptr.h:507:5: note:   template argument deduction/substitution failed:
../../presto_cpp/main/types/PrestoToVeloxSplit.cpp:78:25: error: template argument 1 is invalid
   78 |           connectorSplit)) {
      |

@majetideepak
Copy link
Collaborator Author

@Mionsz CI seems to be building Prestissimo without any errors.
What is your environment?

@majetideepak
Copy link
Collaborator Author

This is resolved with #18367
@Mionsz feel free to open an issue for your build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prestissimo Presto Native Execution
Projects
None yet
Development

No branches or pull requests

2 participants