Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ccd773e

Browse files
committedFeb 24, 2025·
Change from dataSize to long to avoid unnecessary creation
1 parent 9c4b683 commit ccd773e

File tree

58 files changed

+1325
-1295
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+1325
-1295
lines changed
 

‎presto-main/src/main/java/com/facebook/presto/dispatcher/FailedDispatchQuery.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.facebook.presto.spi.resourceGroups.ResourceGroupId;
2424
import com.facebook.presto.spi.resourceGroups.ResourceGroupQueryLimits;
2525
import com.google.common.util.concurrent.ListenableFuture;
26-
import io.airlift.units.DataSize;
2726
import io.airlift.units.Duration;
2827
import org.joda.time.DateTime;
2928

@@ -34,7 +33,6 @@
3433
import static com.facebook.presto.execution.QueryState.FAILED;
3534
import static com.facebook.presto.server.BasicQueryInfo.immediateFailureQueryInfo;
3635
import static com.google.common.util.concurrent.Futures.immediateFuture;
37-
import static io.airlift.units.DataSize.Unit.BYTE;
3836
import static java.util.Objects.requireNonNull;
3937
import static java.util.concurrent.TimeUnit.MILLISECONDS;
4038

@@ -178,15 +176,15 @@ public Duration getTotalCpuTime()
178176
}
179177

180178
@Override
181-
public DataSize getTotalMemoryReservation()
179+
public long getTotalMemoryReservationInBytes()
182180
{
183-
return new DataSize(0, BYTE);
181+
return 0L;
184182
}
185183

186184
@Override
187-
public DataSize getUserMemoryReservation()
185+
public long getUserMemoryReservationInBytes()
188186
{
189-
return new DataSize(0, BYTE);
187+
return 0L;
190188
}
191189

192190
@Override

‎presto-main/src/main/java/com/facebook/presto/dispatcher/LocalDispatchQuery.java

+6-8
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import com.google.common.util.concurrent.Futures;
3535
import com.google.common.util.concurrent.ListenableFuture;
3636
import com.google.common.util.concurrent.SettableFuture;
37-
import io.airlift.units.DataSize;
3837
import io.airlift.units.Duration;
3938
import org.joda.time.DateTime;
4039

@@ -53,7 +52,6 @@
5352
import static com.facebook.presto.spi.StandardErrorCode.USER_CANCELED;
5453
import static com.facebook.presto.util.Failures.toFailure;
5554
import static com.google.common.util.concurrent.Futures.nonCancellationPropagating;
56-
import static io.airlift.units.DataSize.Unit.BYTE;
5755
import static java.util.Objects.requireNonNull;
5856
import static java.util.concurrent.TimeUnit.MILLISECONDS;
5957

@@ -303,19 +301,19 @@ public Duration getTotalCpuTime()
303301
}
304302

305303
@Override
306-
public DataSize getTotalMemoryReservation()
304+
public long getTotalMemoryReservationInBytes()
307305
{
308306
return tryGetQueryExecution()
309-
.map(QueryExecution::getTotalMemoryReservation)
310-
.orElseGet(() -> new DataSize(0, BYTE));
307+
.map(QueryExecution::getTotalMemoryReservationInBytes)
308+
.orElse(0L);
311309
}
312310

313311
@Override
314-
public DataSize getUserMemoryReservation()
312+
public long getUserMemoryReservationInBytes()
315313
{
316314
return tryGetQueryExecution()
317-
.map(QueryExecution::getUserMemoryReservation)
318-
.orElseGet(() -> new DataSize(0, BYTE));
315+
.map(QueryExecution::getUserMemoryReservationInBytes)
316+
.orElse(0L);
319317
}
320318

321319
public int getRunningTaskCount()

0 commit comments

Comments
 (0)
Please sign in to comment.