From c3c7713ed8bbbe3e14fa85de397a3ad131744500 Mon Sep 17 00:00:00 2001 From: Andrii Rosa Date: Wed, 20 Nov 2024 15:07:08 -0800 Subject: [PATCH] Enable scaled-writers by default --- .../facebook/presto/sql/analyzer/FeaturesConfig.java | 4 ++-- .../presto/sql/analyzer/TestFeaturesConfig.java | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java index dea97b8d6fd21..949e76ff28876 100644 --- a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java +++ b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java @@ -103,8 +103,8 @@ public class FeaturesConfig private String historyBasedOptimizerPlanCanonicalizationStrategies = "IGNORE_SAFE_CONSTANTS"; private boolean logPlansUsedInHistoryBasedOptimizer; private boolean enforceTimeoutForHBOQueryRegistration; - private boolean redistributeWrites = true; - private boolean scaleWriters; + private boolean redistributeWrites; + private boolean scaleWriters = true; private DataSize writerMinSize = new DataSize(32, MEGABYTE); private boolean optimizedScaleWriterProducerBuffer = true; private boolean optimizeMetadataQueries; diff --git a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java index 86f9263c1c9d7..fef504e0612a6 100644 --- a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java +++ b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java @@ -86,8 +86,8 @@ public void testDefaults() .setHistoryBasedOptimizerPlanCanonicalizationStrategies("IGNORE_SAFE_CONSTANTS") .setLogPlansUsedInHistoryBasedOptimizer(false) .setEnforceTimeoutForHBOQueryRegistration(false) - .setRedistributeWrites(true) - .setScaleWriters(false) + .setRedistributeWrites(false) + .setScaleWriters(true) .setWriterMinSize(new DataSize(32, MEGABYTE)) .setOptimizedScaleWriterProducerBuffer(true) .setOptimizeMetadataQueries(false) @@ -295,8 +295,8 @@ public void testExplicitPropertyMappings() .put("optimizer.log-plans-used-in-history-based-optimizer", "true") .put("optimizer.enforce-timeout-for-hbo-query-registration", "true") .put("optimizer.history-based-optimizer-timeout", "1s") - .put("redistribute-writes", "false") - .put("scale-writers", "true") + .put("redistribute-writes", "true") + .put("scale-writers", "false") .put("writer-min-size", "42GB") .put("optimized-scale-writer-producer-buffer", "false") .put("optimizer.optimize-metadata-queries", "true") @@ -487,8 +487,8 @@ public void testExplicitPropertyMappings() .setHistoryBasedOptimizerPlanCanonicalizationStrategies("IGNORE_SAFE_CONSTANTS,IGNORE_SCAN_CONSTANTS") .setLogPlansUsedInHistoryBasedOptimizer(true) .setEnforceTimeoutForHBOQueryRegistration(true) - .setRedistributeWrites(false) - .setScaleWriters(true) + .setRedistributeWrites(true) + .setScaleWriters(false) .setWriterMinSize(new DataSize(42, GIGABYTE)) .setOptimizedScaleWriterProducerBuffer(false) .setOptimizeMetadataQueries(true)