From 71bb174452828d684ea1cf147004214b2aac5a39 Mon Sep 17 00:00:00 2001 From: Amit Dutta Date: Sun, 24 Mar 2024 19:21:38 -0700 Subject: [PATCH] [native] Minor refactor in ConfigReader. --- .../presto_cpp/main/common/ConfigReader.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp b/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp index 428188042fecf..fe94a3a7ef3c2 100644 --- a/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp +++ b/presto-native-execution/presto_cpp/main/common/ConfigReader.cpp @@ -32,13 +32,14 @@ std::unordered_map readConfig( std::string line; while (getline(configFile, line)) { line.erase(std::remove_if(line.begin(), line.end(), isspace), line.end()); - if (line[0] == '#' || line.empty()) { + if (line.empty() || line[0] == '#') { continue; } - auto delimiterPos = line.find('='); - auto name = line.substr(0, delimiterPos); - auto value = line.substr(delimiterPos + 1); - properties.emplace(name, value); + + std::vector configParts; + folly::split('=', line, configParts); + VELOX_USER_CHECK_EQ(configParts.size(), 2, "Malformed config: {}", line); + properties.emplace(configParts[0], configParts[1]); } return properties;