From 4bd91159a3cd0373b5db89f93ba10be50684b26e Mon Sep 17 00:00:00 2001
From: Rebecca Schlussel <rschlussel@fb.com>
Date: Thu, 21 Mar 2024 16:54:30 -0400
Subject: [PATCH] Add logging to AbstractVerification

Add logging to AbstractVerification to help with debugging flakiness in
TestCreateViewVerification.testRunningInQueryBankMode().
https://github.com/prestodb/presto/issues/20863
---
 .../presto/verifier/framework/AbstractVerification.java        | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java b/presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
index 9b0b4b33b2c75..ac6224bd0b8c7 100644
--- a/presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
+++ b/presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
@@ -13,6 +13,7 @@
  */
 package com.facebook.presto.verifier.framework;
 
+import com.facebook.airlift.log.Logger;
 import com.facebook.presto.jdbc.QueryStats;
 import com.facebook.presto.sql.SqlFormatter;
 import com.facebook.presto.sql.tree.Statement;
@@ -73,6 +74,7 @@
 public abstract class AbstractVerification<B extends QueryBundle, R extends MatchResult, V>
         implements Verification
 {
+    private static final Logger LOG = Logger.get(AbstractVerification.class);
     private static final String INTERNAL_ERROR = "VERIFIER_INTERNAL_ERROR";
     private static final String SNAPSHOT_DOES_NOT_EXIST = "SNAPSHOT_DOES_NOT_EXIST";
 
@@ -277,6 +279,7 @@ else if ((isControlEnabled()) && !skipChecksum) {
         catch (Throwable t) {
             if (exceptionClassifier.shouldResubmit(t)
                     && verificationContext.getResubmissionCount() < verificationResubmissionLimit) {
+                LOG.info("Error during verification: %s", t);
                 return new VerificationResult(this, true, Optional.empty());
             }
             throwable = Optional.of(t);