Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sitemap=false annotation #39

Closed
davidgorges opened this issue Nov 19, 2013 · 4 comments
Closed

Support sitemap=false annotation #39

davidgorges opened this issue Nov 19, 2013 · 4 comments
Assignees

Comments

@davidgorges
Copy link

It's currently not supported to set the sitemap option to "false".

Presta/SitemapBundle/EventListener/RouteAnnotationEventListener.php line 97 {"exception":"[object] (InvalidArgumentException: the sitemap option must be "true" or an array of parameters at /home/www/wwwroot/sf2_widge_prod/shared/vendor/presta/sitemap-bundle/Presta/SitemapBundle/EventListener/RouteAnnotationEventListener.php:97

That's bad style. It shoudl accept the values true and false and the sitemap parameters as an additional parameter.

@ghost ghost assigned halundraN Nov 20, 2013
@halundraN
Copy link
Member

Hello,

I'm agree but I'm currently finishing a project and I do not have time to take care for now. If you can do a pull request, I will try to treat it at the earliest.
Thanks!

@nicolas-bastien
Copy link
Contributor

?

@nicolas-bastien
Copy link
Contributor

@davidgorges can you PR a correction ?

@yann-eugone yann-eugone assigned yann-eugone and unassigned halundraN Oct 20, 2015
@yann-eugone
Copy link
Member

This will be done in the next major release. See #92.
I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants