Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with auto-update routine #62

Closed
SteelWagstaff opened this issue Feb 28, 2023 · 6 comments
Closed

Fix problem with auto-update routine #62

SteelWagstaff opened this issue Feb 28, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@SteelWagstaff
Copy link
Member

SteelWagstaff commented Feb 28, 2023

I've noticed a problem with our autoupdate process:

  1. In pressbooks/pressbooks, we have a post-commit action for dependabot PRs that autobuilds assets and commits them to the PR: https://github.com/pressbooks/pressbooks/blob/dev/.github/workflows/autobuild-dependabot-assets.yml. The problem here is that the PR cannot be merged because it skips the required 'lint & build assets' steps after this commit has been made. See chore: bump instantsearch.js from 4.51.0 to 4.51.1 pressbooks#3206 or screenshot below
    Screenshot from 2023-02-28 11-42-32
@SteelWagstaff SteelWagstaff added the bug Something isn't working label Feb 28, 2023
@SteelWagstaff SteelWagstaff changed the title Fix problems with auto-update routine Fix problem with auto-update routine Mar 1, 2023
@SteelWagstaff
Copy link
Member Author

2 appears to have resolved itself. Maybe was a temporary GitHub issue?

@tw77
Copy link

tw77 commented Mar 8, 2023

Suggested approach: replace the open and merge PR with auto-commit. See if that resolves it.

@arzola
Copy link
Contributor

arzola commented Oct 24, 2023

We've been having some issues with Dependabot checks, probably related to not being able to access to Composer_PAT

See
https://github.com/pressbooks/pressbooks-results-for-lms/actions/runs/6617376245/job/17973549168?pr=103

dependabot/dependabot-core#5464

@ho-man-chan ho-man-chan assigned ho-man-chan and unassigned arzola Feb 27, 2024
@ho-man-chan
Copy link
Contributor

ho-man-chan commented Feb 27, 2024

Update:

Questions:

  1. For the issue with 'lint & build assets' action, I can't seem to see what it is called. Can @arzola let me know where it is called? https://github.com/pressbooks/pressbooks/actions/workflows/required/pressbooks/reusable-workflows/lint-build.yml

image.png

@SteelWagstaff
Copy link
Member Author

@ho-man-chan it's this one: https://github.com/pressbooks/pressbooks/blob/dev/.github/workflows/autobuild-dependabot-assets.yml. I don't think this is the most important issue to adjust, though.

@SteelWagstaff
Copy link
Member Author

Superceded by pressbooks/reusable-workflows#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants