From 1993cad26eaf623a46a70b8d4dd0808076d2e894 Mon Sep 17 00:00:00 2001 From: Jasper Orschulko Date: Thu, 1 Sep 2022 17:53:40 +0200 Subject: [PATCH] Fix url validation regex Fix a bug where toplevel domains containing a "-" would falsely be flagged as invalid --- config/issuetracker.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/config/issuetracker.go b/config/issuetracker.go index 0f4829d..0423525 100644 --- a/config/issuetracker.go +++ b/config/issuetracker.go @@ -40,11 +40,11 @@ var validIssueTrackers = []IssueTracker{ } var originPatterns = map[IssueTracker]*regexp.Regexp{ - IssueTrackerJira: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?$`), + IssueTrackerJira: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?$`), IssueTrackerGithub: regexp.MustCompile(`^(https?://)?(www\.)?github\.com/[\w-]+/[\w-]+`), - IssueTrackerGitlab: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?/[\w-]+/[\w-]+$`), + IssueTrackerGitlab: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?/[\w-]+/[\w-]+$`), IssueTrackerPivotal: regexp.MustCompile(`^(https?://)?(www\.)?pivotaltracker\.com/n/projects/[0-9]+`), - IssueTrackerRedmine: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9]+)+(:[0-9]+)?$`), + IssueTrackerRedmine: regexp.MustCompile(`^(https?://)?[a-zA-Z0-9\-]+(\.[a-zA-Z0-9\-]+)+(:[0-9]+)?$`), IssueTrackerYoutrack: regexp.MustCompile(`^(https?://)?(www\.)?[0-9A-z-]{2,}\/?.*$`), IssueTrackerAzure: regexp.MustCompile(`^(https?://)?(www\.)?dev\.azure\.com/([a-zA-Z0-9]+)+\/([a-zA-Z0-9]+)+.*$`), }