Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set token via environment variables #2

Closed
abatilo opened this issue Jul 18, 2020 · 4 comments · Fixed by #20
Closed

Set token via environment variables #2

abatilo opened this issue Jul 18, 2020 · 4 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@abatilo
Copy link

abatilo commented Jul 18, 2020

I think being able to set tokens via environment variables would end up with a much more CI friendly user experience.

Then the token could be set on the CI provider as a secret.

@preslavmihaylov
Copy link
Owner

That makes sense. I will consider this in a future release.

In the meantime, have in mind it is still possible to specify the auth token for CI by explicitly setting it in your tokens cache (default ~/.todocheck/authtokens.yaml):

Ref. Configuration

Does this way of passing the token work for your needs?

@preslavmihaylov preslavmihaylov added the enhancement New feature or request label Jul 19, 2020
@abatilo
Copy link
Author

abatilo commented Jul 19, 2020

Yes, it's workable for now. I just need CI steps that will write the file for me.

Thanks!

@preslavmihaylov
Copy link
Owner

I'm wondering if specifying an auth token via an environment variable directly might be vulnerable?

Is it common to pass secrets to CI env in that way, could you share some example of this/docs so that I can explore?

@abatilo
Copy link
Author

abatilo commented Jul 19, 2020

I'm wondering if specifying an auth token via an environment variable directly might be vulnerable?

Is it common to pass secrets to CI env in that way, could you share some example of this/docs so that I can explore?

https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

https://circleci.com/docs/2.0/env-vars/#secrets-masking

Many CI systems support setting secrets this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants