Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does napi default to true or false? Docs think false. #77

Closed
jsumners-nr opened this issue Feb 22, 2024 · 1 comment · Fixed by #78
Closed

Does napi default to true or false? Docs think false. #77

jsumners-nr opened this issue Feb 22, 2024 · 1 comment · Fixed by #78

Comments

@jsumners-nr
Copy link
Contributor

| `--napi` | - | `false` | Make [Node-API][node-api] build(s).<br>Targets default to latest node which is compatible with Electron > 3, which can be overridden with `--target`. Note: `--all` should be avoided for now because it includes targets that don't support Node-API.

This line is incorrect as far as I can tell:

prebuildify/bin.js

Lines 22 to 24 in d6d6981

default: {
napi: true
}

Which caused me a lot of confusion until I discovered the following through some local debugging:

#64 (comment)

prebuildify is geared towards Node-API, so the version of the executing node process is not necessarily the right version. It defaults to compiling against the latest node version

@vweevers
Copy link
Member

The default recently changed in 4300cf4 and we forgot to update the README. That should say true. PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants