-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading of fonts #112
Comments
I would love a reproduction to see what is going on. But sounds good to me. |
If I don't add
I get the following errorr when I try to import
There are similar errors for all files with I think that the problem is this @font-face {
font-family: 'FontAwesome';
src: url('../fonts/fontawesome-webfont.eot?v=4.6.3');
src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.6.3') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff2?v=4.6.3') format('woff2'), url('../fonts/fontawesome-webfont.woff?v=4.6.3') format('woff'), url('../fonts/fontawesome-webfont.ttf?v=4.6.3') format('truetype'), url('../fonts/fontawesome-webfont.svg?v=4.6.3#fontawesomeregular') format('svg');
font-weight: normal;
font-style: normal;
} The loader has problems to get
But I just found out that other fonts ex.
And the loader does not load this either. So the better solution which worked for me would be to change it to
This will ignore the version number. |
@kujtimiihoxha Thanks for the solution proposal There is actually one unnecessary question mark (that could cause other issues), you could use
instead of
The question mark makes the extension optional, which is not what we want |
@kartsims Is there a posibility that some fonts are not versioned ? If there are fonts that are not versioned than we should leave it optional. |
The first question mark doesn't make the version optional, but the extension. The second question mark remains to make the version optional. In a regexp the question mark makes the preceding character/expression optional see this website for instance Works fine for me without the first one |
Great than I hope this solution solves other users issues. |
I suggest to change
to
This was needed for example to load
font-awesome
.The text was updated successfully, but these errors were encountered: