New Video Module, BidsMarkedAsUsed/ rendered

[spormeon]

@karimMourra On the new video module, the marked as "rendered" seems to be in the "status" and not the "rendered", should this then set "true" in the rendered so as if we use useBidCache: true, bids can be cached for the TTL?

[patmmccann]

Thanks for the report!

[karimMourra]

@spormeon where are these values read from ? For context, when we determine a bid has been used, we call markWinningBidAsUsed on pbGlobal. Should we be doing something else as well ? Would you happen to have examples of modules that properly mark bids as used for us to work off of ?

[karimMourra]

@spormeon i took a stab in #9612 - could you please verify that this fixes your issue ?

[spormeon]

still seems to be "rendered: false" in V7.39.0. From my understanding this is the mech that is used for "banner", so as prebid stores the bids when useBidCache: true is used. I think i've got this right that if you have a pre-roll with 3 bids of bidA=$2, bidB=2.5, bidC=2.2. bidB is rendered/ used in the first auction, then the bidA & C are stored in cache, so if auction B only gets 1, 1.4 & 1.8 bids. Prebid then uses bidC=2.2 from first auction if still in TTL ( mostly lkely is, as video usually 300 or so). So it only gets "marked off/ wipped out" once status = true. Where the mech is stored i've no real clue, maybe @patmmccann prb knows that off top of his head. I'm not even sure if this is tech possible with video, wasnt before, but hey maybe this new mdoule can change things?

These docs:https://docs.prebid.org/dev-docs/faq.html#does-prebidjs-cache-bids but patrick have a better idea of where to point you to the code etc than me

[patmmccann]

You can see cached bids stored on pbjs.adUnits

[karimMourra]

@spormeon #9612 is not in v7.39.0 because it has not yet been merged - please checkout the branch and test locally and let me know if it fixes your issue. Otherwise please provide reproduction steps so I can test myself.

[spormeon]

i think i got it going locally, i get this error though:

basically i just added your lines in the files and ran gulp serve-and-test --file prebid.js , then used http://localhost:9999/Prebid.js/integrationExamples/videoModule/videojs/bidMarkedAsUsed.html

[spormeon]

#9612 dont solve the problem by looks, actually makes it worse as it drops the: status: "rendered" now, not set the rendered: true/ false

[spormeon]

ye #9612 totally breaks it, its "re using" the same auction id, so its thinking that first auction win, is now the winner on all following slots, because stats: "rendered" has gone i think:

prebid v7.41.0 is basically useless to this point, so i'd flag a warning, dont use it, with bidcache true/false, does it.

[patmmccann]

@spormeon assuming this is solved with #10014 ?

[spormeon]

@patmmccann Ye that solves that. I think the potenetial problem around if a "freak" high bid wins the first bid and bidcache is on, and never gets "out bid", its has the potential to win every subsequent bid

[dgirardi]

Closing this with #10014. If you're still having other problems, feel free to open separate issues for them.