-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubmatic adapter should use site.content.data instead of private dctr param #9142
Comments
FYI - tangentially related to #9141 |
also tagging @jlquaccia Aside: @jlquaccia we'd love to draft you as a reviewer. We very much appreciate your recent contributions. |
@patmmccann thanks! sounds good to me. Also, thanks for the heads up on this gh issue. I should be able to take a look soon sometime next week |
hey @ramkrishan-ravi, @deepak-dhage, @pm-nitin-shirsat, @pm-azhar-mulla , @pm-nilesh-chate, @sachin-pubmatic Jumping back into this, wanted to put this ticket back on the radar (as it got a bit ice-boxed). PR with frontend changes for this ticket has been ready, can one of you please take on the remainder of work for this ticket? Need to know if merging #9169 will have an impact on translator and if so could we address any necessary changes? Know there was some movement on prior discussion before on the potential impact risks of merging 9169. |
@jlquaccia Cafemedia may need to run a version of prebid with 9169 despite any revenue loss to Pubmatic, we cannot continue to wait |
@patmmccann really sorry for the wait on this one, spoke internally, we will make the necessary changes on our end. In the meantime you are good to go with #9169, it can be merged. |
Thanks! |
fixed on #9169 |
Type of issue
efficiency
Description
We found that there can be many hundreds of Seller-Defined Audience segments defined in a request in site.content.data.
Further, we noticed that pubmatic is copying all of them to a bidder-specific dctr parameter before sending to Prebid Server
Here's an example:
We would like Pubmatic to become more efficient here:
thanks
Heads up: @pm-nitin-shirsat , @pm-azhar-mulla , @pm-harshad-mane, @pm-nilesh-chate, @sachin-pubmatic
The text was updated successfully, but these errors were encountered: