Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

${CLICKTHROUGH} macro is not documented, and does not work with safeframe #9060

Closed
dgirardi opened this issue Sep 30, 2022 · 2 comments
Closed

${CLICKTHROUGH} macro is not documented, and does not work with safeframe #9060

dgirardi opened this issue Sep 30, 2022 · 2 comments
Assignees
@jlquaccia
Labels
needs docs

Comments

@dgirardi
Copy link
Collaborator

Type of issue

bug?

Description

#5796 introduced the ${CLICKTROUGH} macro for ad markup, to be substituted with the value passed as an option to renderAd. Both the macro and the option are undocumented, and it appears that there is no way to make it work with safeframe (since it does not go through renderAd).
@patmmccann
Copy link
Collaborator

partial dupe of #6130

@ChrisHuie ChrisHuie moved this from Triage to Needs Req in Prebid.js Tactical Issues table Nov 7, 2022
@jlquaccia jlquaccia self-assigned this Nov 23, 2022
@jlquaccia jlquaccia mentioned this issue Nov 23, 2022
Merged
1 task
@jlquaccia
Copy link
Collaborator

Created a PR for this to prebid.github.io here: prebid/prebid.github.io#4176

@patmmccann patmmccann moved this from Needs Req to PR submitted in Prebid.js Tactical Issues table Nov 29, 2022
@dgirardi dgirardi mentioned this issue Feb 2, 2023
Closed
@dgirardi dgirardi mentioned this issue Mar 9, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlquaccia jlquaccia

Labels
needs docs
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patmmccann @jlquaccia @dgirardi