Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps for production builds #8079

Closed
sergunich opened this issue Feb 16, 2022 · 3 comments · Fixed by #8220
Closed

Sourcemaps for production builds #8079

sergunich opened this issue Feb 16, 2022 · 3 comments · Fixed by #8220
Assignees
Labels

Comments

@sergunich
Copy link

sergunich commented Feb 16, 2022

Type of issue

Feature request

Description

Currently, it's possible to have sourcemaps only for development builds but it would be helpful to have the option to generate sourcemaps for production build too.
https://github.com/prebid/Prebid.js/blob/master/gulpfile.js#L205

Other information

The end goal of this is to submit generated sourcemaps to the Sentry to have proper stackframes for the errors:
https://docs.sentry.io/platforms/javascript/sourcemaps/

@dgirardi
Copy link
Collaborator

@sergunich are you asking for the option to generate sourcemaps just when building Prebid directly from source? it would have no effect on for example the bundles generated by the Prebid.org download page or projects that pull Prebid from npm.

@sergunich
Copy link
Author

option to generate sourcemaps just when building Prebid directly from source

Yeah, that's what I meant 👍

@dgirardi
Copy link
Collaborator

dgirardi commented Mar 2, 2022

Understood; I'm going to put this on hold until we upgrade Webpack (which should happen soon - #7935) as that changes a few things about the build.

@dgirardi dgirardi moved this from Open to Ready for Dev in Prebid.js Tactical Issues table Mar 9, 2022
@dgirardi dgirardi moved this from Ready for Dev to Blocked in Prebid.js Tactical Issues table Mar 11, 2022
@dgirardi dgirardi moved this from Blocked to Ready for Dev in Prebid.js Tactical Issues table Mar 24, 2022
@dgirardi dgirardi moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Mar 25, 2022
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants