Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beachfront video bids missing creativeId #6935

Closed
nanek opened this issue Jun 3, 2021 · 2 comments
Closed

Beachfront video bids missing creativeId #6935

nanek opened this issue Jun 3, 2021 · 2 comments
Assignees
@patmmccann
Labels
bug

Comments

@nanek
Copy link
Contributor

nanek commented Jun 3, 2021

Type of issue

Bug

Description

In Prebid 4.41.0, beachfront video bids are not considered valid. Works fine in Prebid 4.10.0.

Screen Shot 2021-06-03 at 5 38 20 PM

bidResponse requires creativeId to be set. Beachfront adapter tries to pull this from the response.body crid, however as shown in the screenshot below it does not exist in the response.
https://github.com/prebid/Prebid.js/blob/master/modules/beachfrontBidAdapter.js#L81

Screen Shot 2021-06-03 at 5 35 27 PM

This appears related to the change made in #6842

Steps to reproduce

Test page

Expected results

Actual results

Platform details

All

Other information
@patmmccann
Copy link
Collaborator

@jsalis appears to be from removal of ' || response.cmpId,' ?

@patmmccann patmmccann self-assigned this Jun 4, 2021
@patmmccann patmmccann added the bug label Jun 4, 2021
@patmmccann patmmccann mentioned this issue Jun 4, 2021
Merged
9 tasks
@jsalis
Copy link
Contributor

jsalis commented Jun 7, 2021

Thanks for the fix. Seems I moved too fast with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patmmccann patmmccann

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nanek @patmmccann @jsalis