You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changing globalVarName in package.json is supposed to change the pbjs global, but doing so breaks some tests, and an adapter
pbjs hardcoded references:
/modules/
./bidfluenceBidAdapter.js - Used as a variable name, ok
./conversantBidAdapter.js - Used in a comment, ok
./eplanningBidAdapter.js - Used in query string and comment, ok
./express.js - Used in a comment, ok
./gumgumBidAdapter.js - Not sure, tests don't fail. ok?
./indexExchangeBidAdapter.js - Used in query string, ok
./jcmBidAdapter.js - Hardcoded into callback initialization (Breaks adapter and test)
./rubiconBidAdapter.js - Used in string, ok
./smartadserverBidAdapter.js - Used in string, ok
/test/spec/modules/
I'm not as familiar with the testing system so I didn't go through these.
I did a rudimentary find/replace with $$PREBID_GLOBAL$$ and I was able to get the failed tests to pass, but that broke several others that were using pbjs string in ways unrelated to globalVarName
The text was updated successfully, but these errors were encountered:
Type of issue
Bug
Description
Changing
globalVarName
inpackage.json
is supposed to change thepbjs
global, but doing so breaks some tests, and an adapterpbjs
hardcoded references:/modules/
/test/spec/modules/
I'm not as familiar with the testing system so I didn't go through these.
Steps to reproduce
gulp serve
, wait for tests to passpackage.json
changeglobalVarName
topbjs2
gulp serve
, wait for tests to passExpected results
All tests pass both times
Actual results
Tests fail when
globalVarName
isn'tpbjs
Other information
I did a rudimentary find/replace with$$PREBID_GLOBAL$$ and I was able to get the failed tests to pass, but that broke several others that were using
pbjs
string in ways unrelated to globalVarNameThe text was updated successfully, but these errors were encountered: