Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubGears Unit Tests Fail on IE #1360

Closed
dbemiller opened this issue Jul 10, 2017 · 2 comments
Closed

PubGears Unit Tests Fail on IE #1360

dbemiller opened this issue Jul 10, 2017 · 2 comments
Labels

Comments

@dbemiller
Copy link
Contributor

dbemiller commented Jul 10, 2017

Type of issue

Bug

Description

This has been happening for a long time... but I found the root cause while working on #1355, after fixing the source-maps so that I could see line numbers.

The PubGears unit tests use CustomEvent, which isn't supported on IE.

These test failures make Prebid releases harder to validate, and prevent us from automating them.

Failed test output

5) should call bidManager.addBidResponse() when bid received
     PubGearsAdapter bids received
     TypeError: Object doesn't support this action
   at Anonymous function (webpack:///test/spec/modules/pubgearsBidAdapter_spec.js:202:6 <- test/spec/modules/pubgearsBidAdapter_spec.js:2615:7)

6) should send correct bid response object when receiving onBidResponse event
     PubGearsAdapter bids received
     TypeError: Object doesn't support this action
   at Anonymous function (webpack:///test/spec/modules/pubgearsBidAdapter_spec.js:238:6 <- test/spec/modules/pubgearsBidAdapter_spec.js:2651:7)

7) should send $0 bid as no-bid response
     PubGearsAdapter bids received
     TypeError: Object doesn't support this action
   at Anonymous function (webpack:///test/spec/modules/pubgearsBidAdapter_spec.js:276:6 <- test/spec/modules/pubgearsBidAdapter_spec.js:2689:7)
@dbemiller
Copy link
Contributor Author

@Walexander Please look into these when you get the chance.

@matthewlane
Copy link
Collaborator

Closing with Pubgears adapter and test not in 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants