From be6704bcec65a28d80b6d09a8d1c51ef9a8ba824 Mon Sep 17 00:00:00 2001 From: evanmsmrtb Date: Wed, 23 Oct 2019 10:14:50 -0500 Subject: [PATCH] Update smartrtbBidAdapter (#4362) * modules: Implement SmartRTB adapter and spec. * Fix for-loop syntax to support IE; refactor getDomain out of exported set. * Remove debugs, update doc * Update test for video support * Handle missing syncs. Add video to media types in sample ad unit * Add null response check, update primary endpoint * Note smrtb video requires renderer * Remove old params checks, fix documentation playerSize field name --- modules/smartrtbBidAdapter.js | 5 +---- modules/smartrtbBidAdapter.md | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/modules/smartrtbBidAdapter.js b/modules/smartrtbBidAdapter.js index f99c4a58680..10d23a0ccc7 100644 --- a/modules/smartrtbBidAdapter.js +++ b/modules/smartrtbBidAdapter.js @@ -17,11 +17,8 @@ function getDomain () { export const spec = { code: BIDDER_CODE, supportedMediaTypes: [ 'banner', 'video' ], - aliases: ['smrtb'], isBidRequestValid: function(bid) { - return (bid.params.pubId !== null && - bid.params.medId !== null && - bid.params.zoneId !== null); + return (bid.params.zoneId !== null); }, buildRequests: function(validBidRequests, bidderRequest) { let stack = (bidderRequest.refererInfo && diff --git a/modules/smartrtbBidAdapter.md b/modules/smartrtbBidAdapter.md index c44903114cf..7db07ae3fa1 100644 --- a/modules/smartrtbBidAdapter.md +++ b/modules/smartrtbBidAdapter.md @@ -24,7 +24,7 @@ Video is supported but requires a publisher supplied adunit renderer at this tim }, video: { /* requires publisher supplied renderer */ context: 'outstream', - playerDimension: [640, 480] + playerSize: [640, 480] } }, bids: [