From 561b10be61d9709dba3a1c5fe72559de432209f5 Mon Sep 17 00:00:00 2001 From: Demetrio Girardi Date: Fri, 20 May 2022 10:27:31 -0700 Subject: [PATCH] convert bidders: gumgum --- modules/gridNMBidAdapter.js | 2 +- modules/growadvertisingBidAdapter.js | 3 ++- modules/gumgumBidAdapter.js | 2 +- test/spec/modules/gridNMBidAdapter_spec.js | 4 ++-- test/spec/modules/gumgumBidAdapter_spec.js | 8 ++++---- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/modules/gridNMBidAdapter.js b/modules/gridNMBidAdapter.js index 3c46b25b8e1..63c42f60933 100644 --- a/modules/gridNMBidAdapter.js +++ b/modules/gridNMBidAdapter.js @@ -67,7 +67,7 @@ export const spec = { const requests = []; let { bidderRequestId, auctionId, gdprConsent, uspConsent, timeout, refererInfo } = bidderRequest || {}; - const referer = refererInfo ? encodeURIComponent(refererInfo.referer) : ''; + const referer = refererInfo ? encodeURIComponent(refererInfo.page) : ''; bids.forEach(bid => { let user; diff --git a/modules/growadvertisingBidAdapter.js b/modules/growadvertisingBidAdapter.js index 286d27607c5..0fdca8265c6 100644 --- a/modules/growadvertisingBidAdapter.js +++ b/modules/growadvertisingBidAdapter.js @@ -101,7 +101,8 @@ export const spec = { netRevenue: true, ttl: response.ttl, adUnitCode: request.adUnitCode, - referrer: deepAccess(request, 'refererInfo.referer') + // TODO: is 'page' the right value here? + referrer: deepAccess(request, 'refererInfo.page') }; if (response.hasOwnProperty(NATIVE)) { diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js index f7662f54fae..cf6c390d494 100644 --- a/modules/gumgumBidAdapter.js +++ b/modules/gumgumBidAdapter.js @@ -294,7 +294,7 @@ function buildRequests(validBidRequests, bidderRequest) { const gdprConsent = bidderRequest && bidderRequest.gdprConsent; const uspConsent = bidderRequest && bidderRequest.uspConsent; const timeout = config.getConfig('bidderTimeout'); - const topWindowUrl = bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer; + const topWindowUrl = bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.page; _each(validBidRequests, bidRequest => { const { bidId, diff --git a/test/spec/modules/gridNMBidAdapter_spec.js b/test/spec/modules/gridNMBidAdapter_spec.js index 89efe942c1f..c09aca07cc3 100644 --- a/test/spec/modules/gridNMBidAdapter_spec.js +++ b/test/spec/modules/gridNMBidAdapter_spec.js @@ -184,9 +184,9 @@ describe('TheMediaGridNM Adapter', function () { bidderRequestId: '22edbae2733bf6', auctionId: '1d1a030790a475', timeout: 3000, - refererInfo: { referer: 'https://example.com' } + refererInfo: { page: 'https://example.com' } }; - const referrer = encodeURIComponent(bidderRequest.refererInfo.referer); + const referrer = encodeURIComponent(bidderRequest.refererInfo.page); let bidRequests = [ { 'bidder': 'gridNM', diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js index ebbc1c230f1..1a2641e5133 100644 --- a/test/spec/modules/gumgumBidAdapter_spec.js +++ b/test/spec/modules/gumgumBidAdapter_spec.js @@ -546,7 +546,7 @@ describe('gumgumAdapter', function () { }); it('should handle no gg params', function () { - const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { referer: 'https://www.prebid.org/?param1=foo¶m2=bar¶m3=baz' } })[0]; + const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { page: 'https://www.prebid.org/?param1=foo¶m2=bar¶m3=baz' } })[0]; // no params are in object expect(bidRequest.data.hasOwnProperty('eAdBuyId')).to.be.false; @@ -555,7 +555,7 @@ describe('gumgumAdapter', function () { }); it('should handle encrypted ad buy id', function () { - const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { referer: 'https://www.prebid.org/?param1=foo&ggad=bar¶m3=baz' } })[0]; + const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { page: 'https://www.prebid.org/?param1=foo&ggad=bar¶m3=baz' } })[0]; // correct params are in object expect(bidRequest.data.hasOwnProperty('eAdBuyId')).to.be.true; @@ -567,7 +567,7 @@ describe('gumgumAdapter', function () { }); it('should handle unencrypted ad buy id', function () { - const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { referer: 'https://www.prebid.org/?param1=foo&ggad=123¶m3=baz' } })[0]; + const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { page: 'https://www.prebid.org/?param1=foo&ggad=123¶m3=baz' } })[0]; // correct params are in object expect(bidRequest.data.hasOwnProperty('eAdBuyId')).to.be.false; @@ -579,7 +579,7 @@ describe('gumgumAdapter', function () { }); it('should handle multiple gg params', function () { - const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { referer: 'https://www.prebid.org/?ggdeal=foo&ggad=bar¶m3=baz' } })[0]; + const bidRequest = spec.buildRequests(bidRequests, { refererInfo: { page: 'https://www.prebid.org/?ggdeal=foo&ggad=bar¶m3=baz' } })[0]; // correct params are in object expect(bidRequest.data.hasOwnProperty('eAdBuyId')).to.be.true;