From 931b85869e1aa4faf00199e66271bc50a228f4d1 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:23:45 +0100 Subject: [PATCH 1/4] remove trailing space for void elements --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index db6b6df1..64f00711 100644 --- a/src/index.js +++ b/src/index.js @@ -358,7 +358,7 @@ function _renderToString(vnode, context, isSvgMode, selectValue, parent) { // Emit self-closing tag for empty void elements: if (!html && SELF_CLOSING.has(type)) { - return s + ' />'; + return s + '/>'; } return s + '>' + html + ''; From 52a42f1cd983bf8b6bd9338207418b4e76f00ca7 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:24:07 +0100 Subject: [PATCH 2/4] add changeset --- .changeset/gentle-trains-attack.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/gentle-trains-attack.md diff --git a/.changeset/gentle-trains-attack.md b/.changeset/gentle-trains-attack.md new file mode 100644 index 00000000..49a69a0a --- /dev/null +++ b/.changeset/gentle-trains-attack.md @@ -0,0 +1,5 @@ +--- +'preact-render-to-string': major +--- + +Remove trailing space for void_elements From 9981c66971e9177f0be62ca18331ff78d82f22bd Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:28:55 +0100 Subject: [PATCH 3/4] update tests --- test/render.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/render.test.js b/test/render.test.js index 17391c3a..a3b8b1e2 100644 --- a/test/render.test.js +++ b/test/render.test.js @@ -116,7 +116,7 @@ describe('render', () => { it('should serialize defaultChecked prop to the checked attribute', () => { let rendered = render(), - expected = ``; + expected = ``; expect(rendered).to.equal(expected); }); @@ -240,7 +240,7 @@ describe('render', () => { ), - expected = `
`; + expected = `
`; expect(rendered).to.equal(expected); }); From 592a4ba46da29ea5fcbe4f5de855a97d7d907694 Mon Sep 17 00:00:00 2001 From: Jovi De Croock Date: Mon, 27 Feb 2023 08:08:11 +0100 Subject: [PATCH 4/4] Update gentle-trains-attack.md --- .changeset/gentle-trains-attack.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/gentle-trains-attack.md b/.changeset/gentle-trains-attack.md index 49a69a0a..af5ded71 100644 --- a/.changeset/gentle-trains-attack.md +++ b/.changeset/gentle-trains-attack.md @@ -2,4 +2,6 @@ 'preact-render-to-string': major --- -Remove trailing space for void_elements +Remove trailing space for void_elements, this could fail some test_assertions as +`` will become ``, the other `VOID_ELEMENTS` this will be applied for +can be found [here](https://github.com/preactjs/preact-render-to-string/blob/remove-trailing-space/src/index.js#L368-L385)