Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling componentWillMount on render #6

Closed
mikestead opened this issue Jul 29, 2016 · 3 comments
Closed

Calling componentWillMount on render #6

mikestead opened this issue Jul 29, 2016 · 3 comments
Labels
compat enhancement

Comments

@mikestead
Copy link
Contributor

This may be under the preact-compat domain but relates directly to rendering on the server.

React calls componentWillMount on components when server rendering which some libraries depend upon e.g. isomorphic-style-loader. Is this something you'd consider supporting?

Background facebook/react#2674
@developit
Copy link
Member

Ah, yes - preact-render-to-string should definitely be doing this, so you got the right repo! I can probably try to get this done over the weekend.

@developit
Copy link
Member

Fixed and released in preact-render-to-string@2.8.0! Thanks :)

@mikestead
Copy link
Contributor Author

Awesome, thanks for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikestead @developit