Skip to content

Commit 794cab5

Browse files
committed
Review changes for comments: fix, clarify + make consistent.
1 parent a05f7b6 commit 794cab5

File tree

5 files changed

+111
-103
lines changed

5 files changed

+111
-103
lines changed

lib/iris/fileformats/_nc_load_rules/__init__.py

-4
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,4 @@
99
Interprets CF concepts identified by :mod:`iris.fileformats.cf` to add
1010
components into loaded cubes.
1111
12-
For now : the API mimics :class:`pyke.knowledge_engine.engine`.
13-
As this is aiming to replace the old Pyke-based logic rules.
14-
TODO: simplify once the parallel operation with Pyke is no longer required.
15-
1612
"""

lib/iris/fileformats/netcdf.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ def _load_cube(engine, cf, cf_var, filename):
580580
engine.cube = cube
581581
engine.cube_parts = {}
582582
engine.requires = {}
583-
engine.rule_triggered = OrderedAddableList() # set()
583+
engine.rule_triggered = OrderedAddableList()
584584
engine.filename = filename
585585

586586
# Assert all the case-specific facts.

lib/iris/tests/unit/fileformats/nc_load_rules/actions/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
IN cf : "def _load_cube(engine, cf, cf_var, filename)"
2727
WHERE:
2828
- engine is a :class:`iris.fileformats._nc_load_rules.engine.Engine`
29-
- cf is a CFReader
30-
- cf_var is a CFDAtaVariable
29+
- cf is a :class:`iris.fileformats.cf.CFReader`
30+
- cf_var is a :class:`iris.fileformats.cf.CFDataVariable`
3131
3232
As it's hard to construct a suitable CFReader from scratch, it would seem
3333
simpler (for now) to use an ACTUAL FILE.

0 commit comments

Comments
 (0)