Initial switch to breakpoint APIs

[TylerLeonhardt]

This moves to the new breakpoint APIs in PS 7 which enables the ability to debug actual untitled files!

This will also allow things like Azure Functions to not need a Wait-Debugger in their script.

I also accidentally supported Log Points!

To do this, I created a new service BreakpointService that helps manage this.

I took a bunch of the reflection code from @rjmholt's branch of a similar feature.

NOTE: We should probably discuss the Function breakpoints feature... Today, it works in all versions of PowerShell by creating a temp file on the fly and using that for debugging. That doesn't seem like the best approach... because temp files could go south. Ideally we should use same strategy that I'm doing here for function breakpoints as well... but I feel like that's out of scope for this PR.

Testing checklist

lauch and attaches

• Launch current file
• Launch current file temp console
• attach to process 6.2 to 6.2 (to test legacy behavior)
• attach to process 7.0 to 7.0 (to test new behavior)
• attach to process 7.0 to 6.2 (to test legacy behavior)
• attach to process 6.2 to 7.0 (to test legacy behavior)
• all breakpoint types

Untitled files

• Launch current file
• Launch current file temp console can't be supported without a language server in the temp session... so fail nicely
• all breakpoint types

Breakpoint types

• Regular
• Hit count
• expression
• Log points (new!)

Other

• Watch expresssions

[TylerLeonhardt]

Ah looks like I never wired up Actions at all :) still need to do that

[TylerLeonhardt]

Honestly... After doing this, I kinda wanna rip out the BreakpointDetails types. That will simplify the code I think.

As it is, Action breakpoints dont work at all.

[rkeithhill]

I might be remembering this wrong but in the old architecture, there was a bit of a wall between the protocol handlers specific to VSCode/LSP/DAP and the backend PSES "services" which could be used elsewhere apart from the LSP/DAP protocol. But since then the VSCode LSP is now standard (maybe DAP will be eventually) perhaps that separation isn't as important if you expect everyone to use PSES via LSP/DAP.

[rjmholt]

Honestly... After doing this, I kinda wanna rip out the BreakpointDetails types. That will simplify the code I think.

I had the same thought -- think it's the right way to go

[SeeminglyScience]

Had two pending review comments apparently, also here's what's up with the hang on older versions.

[SeeminglyScience]

I know this is out of scope of this PR, but man I'd love to see these global's removed. We should have a "visible but internal" static API that manages stuff like this I think. Something like:

namespace Whatever.EditorServices.Internal
{
    [EditorBrowsable(EditorBrowsableState.Never)]
    public static class BreakpointStateManager
    {
        [Hidden, EditorBrowsable(EditorBrowsableState.Never)]
        public static bool TestHitCount(string hitCountKeyName, int parsedHitCount);
    }
}

[TylerLeonhardt]

I'm removing the WIP. Things seem to be working.

[rjmholt]

Is this being used?

[TylerLeonhardt]

removed.

[SeeminglyScience]

LGTM, just a couple requests.

Also I didn't see it in the list, but make sure watch expressions are tested in 7.

[SeeminglyScience]

Could this be switched to PSCommand?

new PSCommand()
    .AddCommand("Microsoft.PowerShell.Utility\\Get-Runspace")
    .AddParameter("Name", request.RunspaceName)
    .AddCommand("Microsoft.PowerShell.Utility\\Select-Object")
    .AddParameter("ExpandProperty", "Id")

[TylerLeonhardt]

fixed

[TylerLeonhardt]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
           

Complexity increasing per file
==============================
- src/PowerShellEditorServices/Services/DebugAdapter/Debugging/BreakpointApiUtils.cs  10
- src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs  2
- src/PowerShellEditorServices/Services/DebugAdapter/Handlers/BreakpointHandlers.cs  1
- src/PowerShellEditorServices/Services/DebugAdapter/BreakpointService.cs  13
         

Clones removed
==============
+ src/PowerShellEditorServices/Services/DebugAdapter/DebugService.cs  -2
         

See the complete overview on Codacy