Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Further Sharing of Shared Chats in Chat API #148

Open
3 tasks
vineetshar opened this issue Oct 30, 2024 · 6 comments
Open
3 tasks

Restrict Further Sharing of Shared Chats in Chat API #148

vineetshar opened this issue Oct 30, 2024 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vineetshar
Copy link
Contributor

Description:
Currently, the chat-sharing feature permits secondary sharing, where users with whom a chat is shared (e.g., User B) can share it further with others (e.g., User C). This creates potential privacy and control concerns, as the original chat creator may not intend for additional sharing.

Proposed Solution:

  • Implement restrictions within the Chat API that prevent secondary users from sharing the chat further.
  • Only the original creator (User A) should retain the permission to share access.

Tasks:

  • Update the chat-sharing logic to restrict further sharing permissions to only the chat creator.
  • Add checks within the API to verify user permissions before allowing share actions.
  • Test the sharing restrictions to confirm expected behaviour.

Acceptance Criteria:

  • Only the original creator can share a chat.
  • Secondary users (those with whom a chat is shared) are restricted from sharing the chat further.
@vineetshar vineetshar added bug Something isn't working good first issue Good for newcomers labels Oct 30, 2024
@malikrohail
Copy link

could you assign this to me?

@vineetshar
Copy link
Contributor Author

Hey sure @malikrohail feel free to pick this up.

@malikrohail
Copy link

on it, could you pls share repo guidelines for the pull request?

@vineetshar
Copy link
Contributor Author

vineetshar commented Nov 11, 2024

@malikrohail I dont think we are enforcing a lot yet. Just ensure you follow semantic titles and add comments in code & description in pull request with curl screenshots / api call screenshots as proof of functionality.

@dhirenmathur
Copy link
Contributor

Hi @malikrohail let us know if you need any help

@vineetshar
Copy link
Contributor Author

@dhirenmathur should this not be closed too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants