Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script gem_home fix #16

Open
ysolis opened this issue Sep 28, 2017 · 2 comments
Open

script gem_home fix #16

ysolis opened this issue Sep 28, 2017 · 2 comments

Comments

@ysolis
Copy link

ysolis commented Sep 28, 2017

in the gem_home.sh file we see one particular line in gem_home_push, in line 3:

mkdir -p "$1" && pushd "$1" >/dev/null || return 1

this will try to create the dir for the new $GEM_HOME if this not exists, and if exists, 'fails silently'. this is related to Issues #7 and #9.

I think that gem_home must not try to create the project dir for the $GEM_HOME if not exists, if this happens must fail. With this the script will be more clean and avoid the problems mentioned in the Issues mentioned above.

@postmodern
Copy link
Owner

Interesting point, I will consider this.

@postmodern
Copy link
Owner

pushd would still be necessary, since we use pushd to expand the new working directory and use $PWD to derive the absolute gem_dir path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants