Merge Pomm-symfony-bridge with PommBundle ?

[stood]

The bridge is using by Symfony and Silex, but Silex will be end of life the 18 june 2018

https://symfony.com/blog/the-end-of-silex

And the bridge have a big inconvenient, when we develop a functionality it's not easy to test impact on Symfony Bundle.

[stood]

I'm sorry this issue is already open pomm-project/pomm-service-provider#7

[rdavaillaud]

@sanpii do you wait for any approval from the @chanmix51, or just waiting a PR?

If it's just a PR on the bundle, what will be the possible difficulties to expect?

[sanpii]

@sanpii do you wait for any approval from the @chanmix51, or just waiting a PR?

I was waiting for the EOL. It’s done now 😃

If it's just a PR on the bundle, what will be the possible difficulties to expect?

Breaking changes will be difficult to avoid. I think (it’s just an idea before my morning tea) we could create src/PommBundle and src/SymfonyBridge.

[stood]

After reflexion, I'm wondering if it's a good solution. In the futur, if we want develop a new Bundle with a new component Pomm (other ModelManager for example) we will to duplicate the code.

What do you think?

[rdavaillaud]

🤔
All we are doing here, is merging 2 components which are non longer needed to be separated.

I think it's a good thing, we could then bring some new features to this bundle, maybe split it in PommFoundationBundle, PommModelBundle, PommWhateverBundle later.

[stood]

Hmm, I think it's more complicated. The bridge was develop for to work with silex and symfony. But tomorrow if we want to develop a new Bundle PommWhateverBundle the DatabaseCollector and TypeExtractor for example will be common.