Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise on-disk database #137

Closed
jacogr opened this issue Aug 25, 2018 · 1 comment
Closed

Optimise on-disk database #137

jacogr opened this issue Aug 25, 2018 · 1 comment
Labels
@client-db [enhancement] [refactor]

Comments

@jacogr
Copy link
Member

jacogr commented Aug 25, 2018

Replaces & Closes #127

db-diskdown was created as part of polkadot-js/common#193 and implemented as part of #135

Issues -

  1. It is not space-efficient at all
  2. It has slowdowns as the number of keys increases

Optimise with other node modules, look at aof solutions. It actually needs native module support in worker_threads to allow rocksdb or leveldb, but until then.
@jacogr jacogr mentioned this issue Aug 25, 2018
Closed
@jacogr
Copy link
Member Author

jacogr commented Aug 29, 2018

Enabled combined DB, fine for now.

@jacogr jacogr closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@client-db [enhancement] [refactor]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacogr