Include option for arbitrary accounts as a reward destination

[jack-kearney]

I noticed recently that Substrate now allows staking rewards to be redeemed to arbitrary accounts. However, it looks like this feature hasn't yet been rolled out into polkadot.js.org/apps.

If I understand the logic correctly, seems like this is the only place that would need to be updated.

Is there something else preventing this? If not, I can submit a PR to introduce the new value

[jacogr]

Logged as #3354 so closing this as duplicate.

It needs detection for the different networks since not all support it, which is the only tricky bit. So the adjusted constants should only apply to networks where this is available, as detected.

[jack-kearney]

Gotcha - makes sense!

[jacogr]

So did add support for at least displaying it in the account action page today (and changing when already set). But as of this moment, the best way to set it via the Extrinsics app. Once set though, can be managed via account actions.

Still have no idea how to detect the chains - can hardcode it based on genesisHash, but that is a horrible maintenance overhead tracking all of them. (I guess only Polkadot/Kusama is really important, so can just do it for those 2, i.e. Polkadot will go up on the next upgrade)

... erm, that last comment was horrible, I didn't mean anything else is not important, just that most apps users use those 2.

[jacogr]

@jack-kearney Just FYI, enabled it today globally since it went live on Polkadot (and it already available on Kusama). So will create slight issues with older chains where not available... Not a perfect solution, but can set it anywhere now.

[jack-kearney]

@jacogr Thanks! Super helpful to have in there. No clean solution for detecting the chain is jumping out at me. Will think on this though

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.