Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review-trigger asks for too many reviewers #557

Open
mutantcornholio opened this issue Jan 21, 2025 · 0 comments
Open

review-trigger asks for too many reviewers #557

mutantcornholio opened this issue Jan 21, 2025 · 0 comments

Comments

@mutantcornholio
Copy link
Contributor

Introduced in #60, there's the logic that upon any change re-requests reviews from everyone who has previously approved the PR.

The logic is written separately from review-bot (which IMO shouldn't be the case), and might require a too many reviewers, like in this case: #549 (comment).

While limiting amount of requested reviewers might seem like a good option, there's a possibility that a bunch of people with read permissions will approve the review first, then after pushing some changes, only their reviews will be re-requested.

This should be a functionality of review-bot itself, instead of being a part of review-trigger

@mutantcornholio mutantcornholio changed the title review-trigger is asks for too many reviewers review-trigger asks for too many reviewers Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant