-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish switching to PyO3 0.21's native datetime support, now available with abi3, once Python 3.9 is the minimum version #16199
Comments
I will try to do this. |
Another place that should be updated maybe is |
Is this related to #20111? |
It's not a requirement at least, it's been possible to implement this since Polars dropped 3.8 support (a month or two ago?). |
I'm interested to pick this up if nobody minds. |
I was gonna start on this, unless you've already started @bschoenmaeckers ? |
I’ve started the work on this but was not able to continue because of pyo3 wrongly converting ambiguous datetimes. This is fixed in the next version of pyo3 so we have to wait until then. |
Description
In Python 3.9 there's now a timezone database available. That means PyO3 can have native timezone conversion between
chrono_tz::Tz
and Pythontimezone
objects.Currently Polars has its own custom conversion code, which is likely slower than PyO3's since it's in Python. However, until Python 3.9 is the minimum supported version, this change can't happen. I.e. this should be revisited in November 2024 or later.
(See also #16158, where most of the relevant work was done.)
The text was updated successfully, but these errors were encountered: