From b9d19c256a0369ed074eaa18121bdf2eea9534d0 Mon Sep 17 00:00:00 2001 From: Felicitas Pojtinger Date: Fri, 6 Oct 2023 01:37:54 +0200 Subject: [PATCH] refactor: Shrink buffer if subsequent requests can work with smaller request sizes --- pkg/server/nbd.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/server/nbd.go b/pkg/server/nbd.go index ee45b22..669f9f4 100644 --- a/pkg/server/nbd.go +++ b/pkg/server/nbd.go @@ -330,10 +330,7 @@ n: } // Transmission - var ( - b = []byte{} - maxObservedLength = uint32(0) - ) + b := []byte{} for { var requestHeader protocol.TransmissionRequestHeader if err := binary.Read(conn, binary.BigEndian, &requestHeader); err != nil { @@ -349,10 +346,8 @@ n: return ErrInvalidBlocksize } - if length > maxObservedLength { + if length != uint32(len(b)) { b = make([]byte, length) - - maxObservedLength = length } switch requestHeader.Type {