Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: HTTP requests for the first byte are not ignored #1243

Closed
uduerholz opened this issue Oct 16, 2021 · 0 comments
Closed

Analytics: HTTP requests for the first byte are not ignored #1243

uduerholz opened this issue Oct 16, 2021 · 0 comments
Assignees
Labels

Comments

@uduerholz
Copy link

uduerholz commented Oct 16, 2021

Expected behavior

The database table podlove_downloadintentclean does not contain rows with httprange of one or two bytes
(as described in the documentation).

Actual behavior

The database table podlove_downloadintentclean contains rows with httprange of one or two bytes.

System information

PHP Version 7.4.24
WordPress Version 5.8.1
Active Plugins
- Podlove Podcast Publisher v3.6.1
- Podlove Subscribe Button v1.3.7
- Podlove Web Player v5.4.14
- ...
Publisher Version 3.6.1
Publisher Database Version 152
Web Player Version player_v5
Monolog Version 1
open_basedir ok
curl Version 7.64.0

Suggested fix:

Correct the SQL query in lib/jobs/download_intent_cleanup_job.php:

@ -110,7 +110,7 @@ class DownloadIntentCleanupJob

<<   AND (di.httprange != 'bytes=0-0' OR di.httprange != 'bytes=0-1' OR httprange IS NULL) -- filter out 1 byte requests; allow requests with empty httprange
>>   AND ((di.httprange != 'bytes=0-0' AND di.httprange != 'bytes=0-1') OR di.httprange IS NULL) -- filter out 1 byte requests; allow requests with empty httprange
@uduerholz uduerholz changed the title Analytics: HTTP HEAD requests are not ignored Analytics: HTTP requests for the first byte are not ignored Oct 16, 2021
@eteubert eteubert added the bug label Oct 18, 2021
@eteubert eteubert self-assigned this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants