Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow File Markers #8

Open
nikmd23 opened this issue Nov 20, 2014 · 2 comments
Open

Allow File Markers #8

nikmd23 opened this issue Nov 20, 2014 · 2 comments

Comments

@nikmd23
Copy link

nikmd23 commented Nov 20, 2014

Using comments to annotate a css file would go a long way in making CSS Specificity Graphs more useful (as covered by Snooks).

Here's a mock up of my proposal:
specificity

Notice the CSS comment I added on line 8. This makes the vertical marker/axis appear. The marker has a tool tip sighting the line number and marker comment.

I've added a few other comments in the file as well, which results in additional markers.

Note that this isn't a design suggestion. I don't think that red would be the best choice, but I don't actually care.

@pocketjoso
Copy link
Owner

Thanks for your proposal, and the link to that article - I hadn't seen it yet. I'll do some thinking and research on this topic and come I'll come back and see what I can do here. Feel free to add more to the discussion if you have more input.

@pocketjoso
Copy link
Owner

As for initial discussion - I'm not sure that a CSS comment would be the right mechanism for declaring your mark points. Other mechanisms I consider right now:

  • Clicking on (or otherwise selecting) selector in graph, to drop a line marker.
  • Passing in the mark points as an optionwhen creating the graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants