Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many ifs #1

Open
8 tasks
apotonick opened this issue Aug 21, 2020 · 0 comments
Open
8 tasks

Too many ifs #1

apotonick opened this issue Aug 21, 2020 · 0 comments

Comments

@apotonick
Copy link
Contributor

apotonick commented Aug 21, 2020 •
edited
Loading

  • we cover cases with if and respond_to? that won't happen: https://www.youtube.com/watch?v=mjsnd8dJbew
  • why pluralizaion? Organizations?
  • string keys in options should be symbols
  • why don't you use keyword arguments more often?
  • rename options to ctx
  • remove logging, we have wtf? tracing!
  • remove exceptions/http_status from Authenticate & co.
  • APi::Authenticate::Api still needs endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apotonick