Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about versions and npm #781

Closed
mikezimm opened this issue Jan 8, 2021 · 6 comments
Closed

Question about versions and npm #781

mikezimm opened this issue Jan 8, 2021 · 6 comments

Comments

@mikezimm
Copy link
Contributor

mikezimm commented Jan 8, 2021

@aaclage @estruyf @joelfmrodrigues @Abderahman88

Category

[ ] Enhancement

[ ] Bug

[ x ] Question

Version

That's the question :) I'm just trying to get the update an older project to fix #576.

Expected / Desired Behavior / Question

I am trying to update my project because I need #576 change implemented to fix my issue.
According to that change, I need to be at 1.19 or later.

When I run these npm commands, I would expect it to update the package.json as well.

npm uninstall @pnp/spfx-controls-react
npm install @pnp/spfx-controls-react@1.21.1 --save --save-exact

Observed Behavior

Unless I'm doing something wrong, this is what it shows when I do that.
Why does it show dependencies of
"@pnp/spfx-controls-react": "^1.2.2",

Note that in my screenshot I'm showing I was updating a sample from spfx-webparts repo... I tried both my own project and after getting a similar result, I tried to update the sample repo.

image

Steps to Reproduce

npm uninstall @pnp/spfx-controls-react
npm install @pnp/spfx-controls-react@1.21.1 --save --save-exact
@ghost
Copy link

ghost commented Jan 8, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 8, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jan 8, 2021

Hi @mikezimm,

My only assumption is you're running the commands in another folder. Meaning you're updating some other project.

May it be the case?

@mikezimm
Copy link
Contributor Author

mikezimm commented Jan 8, 2021

@AJIXuMuK , you are 100% correct! I looked at it 3 times and did not realize it.

A simple follow-up if I'm allowed,

Is there any substantial difference (in function or feature) between v1 and v2 in functionality outside of just compatibility with v1.11 projects? Or do you add the same updates to both versions of the library?

Thanks again for the answer!

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jan 8, 2021

@mikezimm,

v2 is more functional than v1.
We're not actively adding functionality to v1 anymore - only by request.
Currently v2 already has some new components (for example Dashboard) that are not available in v1, and there are no plans to include them in v1.

@mikezimm
Copy link
Contributor Author

mikezimm commented Jan 8, 2021

@AJIXuMuK are bug fixes applied to both (assuming they have the same issue)?

Feel free to close with comment.

And again thank you for your answers

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jan 8, 2021

@mikezimm - bug fixes are also added to v1 upon request.

@AJIXuMuK AJIXuMuK closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants