Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel testing to SOPFLOW toml infrastructure #27

Closed
4 tasks
bjpalmer opened this issue Oct 4, 2023 · 1 comment · Fixed by #24
Closed
4 tasks

Add parallel testing to SOPFLOW toml infrastructure #27

bjpalmer opened this issue Oct 4, 2023 · 1 comment · Fixed by #24
Assignees

Comments

@bjpalmer
Copy link
Collaborator

bjpalmer commented Oct 4, 2023

This issue was originally created because tests of SOPFLOW only run with one MPI rank using the CMake variable ${RUNCMD}.

Some of these tests are now running on 3 ranks.

Asher's original issue specified that the driver tests/functionality/sopflow/selfcheck.cpp should be extened to:

  • Pass the number of MPI ranks (MPI_COMM_WORLD_SIZE) to the PflowFunctionalityTests constructor
  • Read in n_procs from each testcase
  • Only use the testcase iff n_procs == MPI_COMM_WORLD_SIZE
  • Correct the number of iterations for each testcase to pass in CI

However, passing the number of MPI ranks to the constructor is a bad way of handling this. A much better way is to pass an MPI communicator to the SOPFLOW constructor. This hasn't been done either, but the SOPFLOWCreate command does take a communicator and uses it to set the communicator of the SOPFLOW object.

@bjpalmer
Copy link
Collaborator Author

bjpalmer commented Oct 4, 2023

@abhyshr, it looks like SOPFLOW has several tests that are running on 3 processes. Can you take a look at the tests/functionality/sopflow/CMakeLists.txt file and see if you are okay with coverage of SOPFLOW on multiple MPI ranks?

@bjpalmer bjpalmer self-assigned this Oct 4, 2023
@bjpalmer bjpalmer linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant