Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svelte-parse] Boolean attribute doesn't get end position #179

Closed
halfnelson opened this issue Nov 10, 2020 · 3 comments · Fixed by #195 or #190
Closed

[svelte-parse] Boolean attribute doesn't get end position #179

halfnelson opened this issue Nov 10, 2020 · 3 comments · Fixed by #195 or #190

Comments

@halfnelson
Copy link
Contributor

<div test></div>

gives

          "type": "svelteProperty",
          "name": "test",
          "value": [],
          "modifiers": [],
          "shorthand": "boolean",
          "position": {
            "start": {
              "line": 1,
              "column": 6,
              "offset": 5
            },
            "end": {}
          }

expected end to have position information

@halfnelson
Copy link
Contributor Author

I also get the same behaviour for directives without an =

<input type="checkbox" bind:group />

gives no end position (it says shorthand="none", but not sure what it should say here)

@pngwn
Copy link
Owner

pngwn commented Nov 28, 2020

I think this should say shorthand='expression' as it is shorthand for bind:group={group}, iirc.

@pngwn
Copy link
Owner

pngwn commented Nov 28, 2020

Not actually convinced about the shorthand thing. Will revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants