TypeConverter: account for possible out-of-range meta in items

dktapps · dktapps · commit c8e1cfcbee49 · 2022-03-18T19:34:51.000Z
diff --git a/src/network/mcpe/convert/TypeConverter.php b/src/network/mcpe/convert/TypeConverter.php
@@ -232,6 +232,9 @@ public function netItemStackToCore(ItemStack $itemStack) : Item{
 				$compound = null;
 			}
 		}
+		if($meta < 0 || $meta >= 0x7fff){ //this meta value may have been restored from the NBT
+			throw new TypeConversionException("Item meta must be in range 0 ... " . 0x7fff . " (received $meta)");
+		}
 
 		try{
 			return ItemFactory::getInstance()->get(

Original file line number	Diff line number	Diff line change
`@@ -232,6 +232,9 @@ public function netItemStackToCore(ItemStack $itemStack) : Item{`
`232`	`232`	`$compound = null;`
`233`	`233`	`}`
`234`	`234`	`}`
	`235`	`+ if($meta < 0 \|\| $meta >= 0x7fff){ //this meta value may have been restored from the NBT`
	`236`	`+ throw new TypeConversionException("Item meta must be in range 0 ... " . 0x7fff . " (received $meta)");`
	`237`	`+ }`
`235`	`238`
`236`	`239`	`try{`
`237`	`240`	`return ItemFactory::getInstance()->get(`