Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_attach regression #217

Closed
SvanT opened this issue Jan 12, 2024 · 2 comments · Fixed by #220
Closed

on_attach regression #217

SvanT opened this issue Jan 12, 2024 · 2 comments · Fixed by #220

Comments

@SvanT
Copy link

SvanT commented Jan 12, 2024

It seems like after this commit:
df64c37
you can no longer disable formatting with this config:

require("typescript-tools").setup({
  on_attach = function(client)
    client.server_capabilities.documentFormattingProvider = false
    client.server_capabilities.documentRangeFormattingProvider = false
  end,
})

Formatting is run even after disabling it with the above config.

@pmizio
Copy link
Owner

pmizio commented Jan 13, 2024

@SvanT I just merged fix for mentioned commit can you check it?

@SvanT
Copy link
Author

SvanT commented Jan 13, 2024

It seems to work with the bugfix/219 branch

Thanks for the fast fix and this awesome project in general :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants