Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on legend group titles should always toggle the group, even when groupclick=item #5911

Open
nicolaskruchten opened this issue Aug 27, 2021 · 8 comments
Labels
bug something broken P3 backlog

Comments

@nicolaskruchten
Copy link
Contributor

Follow up on #5906

@ryanh153
Copy link

This would be a huge plus and make groupclick much more useful. I flip back and forth between the modes as I visualize data from multiple sources and each source provides multiple "views" of the same data. Sometimes all views from a producer will be unhelpful but sometimes a producer that produces many views will have one useful view. So in that case I want be able to easily say "Give me all views from producer 1, no views from producer 2, and the third view from producer 3" which can be cumbersome if each producer gives me up to 100 views.

If anyone has any other suggestions/workarounds in the mean time that would also be helpful.

@janosh
Copy link

janosh commented Nov 30, 2021

Is this the function that would need to change? I can't identify the line it handles legend group title clicks.

return attrIndex;
}
function setVisibility(fullTrace, visibility) {
if(legendItem.groupTitle && !toggleGroup) return;
var fullInput = fullTrace._fullInput;

@Yukams
Copy link

Yukams commented Jan 20, 2022

Am I missing something or you want to revert a previous work with groupclick="toggleitem" in legend ?
I can't really make it work anyway

@archmoj archmoj added the bug something broken label Jan 20, 2022
@archmoj
Copy link
Contributor

archmoj commented Jan 20, 2022

Am I missing something or you want to revert a previous work with groupclick="toggleitem" in legend ? I can't really make it work anyway

No we are not going to revert the previous work.
Just labeled it as a current bug.

@AhmedThahir
Copy link

Any updates?

@hchaudhr
Copy link

Am I missing something or you want to revert a previous work with groupclick="toggleitem" in legend ? I can't really make it work anyway

No we are not going to revert the previous work. Just labeled it as a current bug.

If the group title is clicked then shouldn't it do togglegroup? For example, if I have groupclick = "toggleitem", I want the individual trace to be toggled, but if the group title is clicked I want the group itself to be toggled. Is there a way to implement that?

@AhmedThahir
Copy link

Am I missing something or you want to revert a previous work with groupclick="toggleitem" in legend ? I can't really make it work anyway

No we are not going to revert the previous work. Just labeled it as a current bug.

If the group title is clicked then shouldn't it do togglegroup? For example, if I have groupclick = "toggleitem", I want the individual trace to be toggled, but if the group title is clicked I want the group itself to be toggled. Is there a way to implement that?

This is what exactly what I'm looking for. I really need this

@secretwpn
Copy link

Hi! Could anyone please shed some light on this:
Is it so that the desired behavior is to have a possibility to run a setup like
Something like

        legend: {
          groupclick: 'togglegroup',
          itemclick: 'toggle',
        },

and thus toggle group via group title click and individual trace via respective trace item click?
I know that for my use case this is certainly the desired behavior, just checking if there is consensus about this.

And is it so that this is not currently supported?

In my experience with 2.16.3 individual trace toggling only works with groupclick: 'toggleitem'.
Confusingly, doubleclick, which if i gather correctly defaults to itemdoubleclick:'toggleothers' toggles other groups but keeps other traces within the group, item of which was double clicked, untoggled

@gvwilson gvwilson self-assigned this Jul 4, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added the P3 backlog label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 backlog
Projects
None yet
Development

No branches or pull requests

9 participants