Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Pagination - move current_page out of pagination_settings? #411

Closed
alexcjohnson opened this issue Apr 21, 2019 · 2 comments
Closed

Pagination - move current_page out of pagination_settings? #411

alexcjohnson opened this issue Apr 21, 2019 · 2 comments

Comments

@alexcjohnson
Copy link
Collaborator

current_page is more state than configuration - it would be nice to be able to both create pagination_settings without involving current_page, and to subscribe to current_page in a callback independent of pagination_settings. I might also move pagination_mode to be pagination_settings.mode while we're at it...
@r-chris
Copy link

r-chris commented Jun 25, 2019

I believe the latest release (v4.0.0) removed the pagination_settings altogether to what is now page_action. current_page is probably page_current - so I assume you can close this now?

@alexcjohnson
Copy link
Collaborator Author

Thanks @r-chris you're right - closed by #446

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcjohnson @r-chris