Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Set (or optionally set) setProps even if the component has no shared dependencies #98

Closed
Marc-Andre-Rivet opened this issue Nov 16, 2018 · 1 comment
Labels
Type: Bug Something isn't working as intended

Comments

@Marc-Andre-Rivet
Copy link
Contributor

Marc-Andre-Rivet commented Nov 16, 2018

In dash-renderer 0.13.2 a component will have setProps === undefined if there is not dependency on its properties.

Complex components behavior can be severely impacted if they have no dependency (e.g. if no dash-table prop is used as a dependency, pagination_settings and filter expression are not updated, which prevents the UI from updating itself & shows incorrect information).

Complex components lend themselves well to this problem as there's a higher probability that they are at the top of the component "food-chain" (they depend on others but no one depends on them as they are the "final" view or result for a combination of settings)

*** Update: Do we need to do something similar for fireEvent ?

@alexcjohnson
Copy link
Collaborator

Resolved by #126 if I'm understanding the issue correctly. (and fireEvent is 🔪 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants