This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
ConfirmDialog component can appear multiple times #452
Labels
dash-type-bug
Something isn't working as intended
It appears the ConfirmDialog component can pop-up twice (so you'd need to click "ok" twice) after its initial render. When it is first run, you only need to click "ok" once, but when that same dialog is reused, i.e. in the test linked below, it appears twice and needs to be confirmed twice.
I've come across this bug in the #352 loading component branch, where my changes to dash_renderer (plotly/dash-renderer#93) caused the ConfirmDialog pop-up to appear twice (so you have to click "Ok" twice) from the initial load, and afterwards thrice, which caused this test
dash-core-components/test/test_integration.py
Line 1212 in a7e640c
to fail.
There's probably something going on with dash_renderer's rendering calls, where it re-renders too often and causes these issues, but my feeling is that the ConfirmDialog shouldn't be rendered again if it's already rendered.
The text was updated successfully, but these errors were encountered: