Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

ConfirmDialog component can appear multiple times #452

Open
valentijnnieman opened this issue Jan 31, 2019 · 1 comment
Open

ConfirmDialog component can appear multiple times #452

valentijnnieman opened this issue Jan 31, 2019 · 1 comment
Assignees
Labels
dash-type-bug Something isn't working as intended

Comments

@valentijnnieman
Copy link
Contributor

It appears the ConfirmDialog component can pop-up twice (so you'd need to click "ok" twice) after its initial render. When it is first run, you only need to click "ok" once, but when that same dialog is reused, i.e. in the test linked below, it appears twice and needs to be confirmed twice.

I've come across this bug in the #352 loading component branch, where my changes to dash_renderer (plotly/dash-renderer#93) caused the ConfirmDialog pop-up to appear twice (so you have to click "Ok" twice) from the initial load, and afterwards thrice, which caused this test

def test_confirm_as_children(self):

to fail.

There's probably something going on with dash_renderer's rendering calls, where it re-renders too often and causes these issues, but my feeling is that the ConfirmDialog shouldn't be rendered again if it's already rendered.

@valentijnnieman valentijnnieman added the dash-type-bug Something isn't working as intended label Jan 31, 2019
@T4rk1n T4rk1n self-assigned this Jan 31, 2019
@T4rk1n
Copy link
Contributor

T4rk1n commented Jan 31, 2019

I'll take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants